Add more linters#2092
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 87.61% 87.59% -0.03%
==========================================
Files 96 96
Lines 6695 6698 +3
Branches 50 50
==========================================
+ Hits 5866 5867 +1
- Misses 773 774 +1
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
lucacome
commented
Jun 5, 2024
lucacome
commented
Jun 5, 2024
Contributor
Author
|
Also wondering what you think about the suggested |
Contributor
I'm fine with it. It will be a good reminder for us to try and preallocate when the capacity can be determined, which is in our coding guidelines. |
kate-osborn
reviewed
Jun 20, 2024
github-actions
Bot
added
the
documentation
Contributor
Author
|
I've decided to open a sepate PR for |
sjberman
reviewed
Jun 27, 2024
sjberman
approved these changes
Jun 27, 2024
pleshakov
reviewed
Jun 27, 2024
Problem: We want to catch errors and styling issues as early as possible. Solution: Enable new linters.
pleshakov
approved these changes
Jun 27, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: We want to catch errors and styling issues as early as possible. Solution: Enable new linters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We want to catch errors and styling issues as early as possible.
Solution: Enable new linters.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.